lyndonb-bq commented on a change in pull request #8724:
URL: https://github.com/apache/arrow/pull/8724#discussion_r527978639
##########
File path: cpp/src/arrow/flight/client.cc
##########
@@ -371,7 +375,7 @@ class GrpcClientInterceptorAdapterFactory
}
private:
- std::vector<std::shared_ptr<ClientMiddlewareFactory>> middleware_;
+ std::vector<std::shared_ptr<ClientMiddlewareFactory>>& middleware_;
Review comment:
It was to keep the reference, but you got me thinking more and I think I
should just take a copy and then make a function to allow adding to the
middleware on the fly, since the issue is that I need to be able to add and
remove middleware from the interceptor. I will rejig this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
