lyndonb-bq commented on a change in pull request #8724:
URL: https://github.com/apache/arrow/pull/8724#discussion_r527979053
##########
File path: cpp/src/arrow/flight/client.cc
##########
@@ -963,8 +967,9 @@ class FlightClient::FlightClientImpl {
std::vector<std::unique_ptr<grpc::experimental::ClientInterceptorFactoryInterface>>
interceptors;
+ middleware = std::move(options.middleware);
Review comment:
Goal was so that middleware was retained in this class so I could push
and pop it. I am going to adjust the implementation though.
##########
File path: cpp/src/arrow/flight/client.cc
##########
@@ -993,6 +998,30 @@ class FlightClient::FlightClientImpl {
return Status::OK();
}
+ Status AuthenticateBasicToken(std::string username, std::string password,
Review comment:
yes
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
