paleolimbot commented on code in PR #117: URL: https://github.com/apache/arrow-nanoarrow/pull/117#discussion_r1132389167
########## python/.gitignore: ########## @@ -18,7 +18,8 @@ src/nanoarrow/nanoarrow.c src/nanoarrow/nanoarrow.h -src/nanoarrow/*.cpp +src/nanoarrow/nanoarrow_c.pxd Review Comment: It is a pretty useful file to have on hand...nanoarrow.c/h are built for vendoring and there's no reason another Python package couldn't use the same .pxd (provided it's generated from the correct nanoarrow.h). Maybe it could get checked into the dist/ folder next to the bundled nanoarrow/h? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
