paleolimbot commented on code in PR #117: URL: https://github.com/apache/arrow-nanoarrow/pull/117#discussion_r1132428639
########## python/setup.py: ########## @@ -17,29 +17,23 @@ # specific language governing permissions and limitations # under the License. -import shutil -from pathlib import Path - +import os +import sys +import subprocess from setuptools import Extension, setup - import numpy as np - -# setuptools gets confused by relative paths that extend above the project root -target = Path(__file__).parent / "src" / "nanoarrow" -shutil.copy( - Path(__file__).parent / "../dist/nanoarrow.c", target / "nanoarrow.c" -) -shutil.copy( - Path(__file__).parent / "../dist/nanoarrow.h", target / "nanoarrow.h" -) +# Run bootstrap.py to run cmake generating a fresh bundle based on this +# checkout or copy from ../dist if the caller doesn't have cmake available +this_dir = os.path.dirname(__file__) +subprocess.run([sys.executable, os.path.join(this_dir, 'bootstrap.py')]) Review Comment: There's a bootstrap.R file too and I really like keep the logic separate since it's rather extensive and maybe should even be tested separately. I forgot about sdist...I made a few changes to make sure that (1) bootstrap.py wouldn't be included in sdist and (2) make sure not to error if it isn't there. Probably this will need some workshopping come 'we have to build 39348 wheels' time. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
