paleolimbot commented on code in PR #117: URL: https://github.com/apache/arrow-nanoarrow/pull/117#discussion_r1132722310
########## python/.gitignore: ########## @@ -18,7 +18,8 @@ src/nanoarrow/nanoarrow.c src/nanoarrow/nanoarrow.h -src/nanoarrow/*.cpp +src/nanoarrow/nanoarrow_c.pxd Review Comment: Checking it into dist/ would be fine because users of that would just copy the whole folder into their python project and the .h/.pxd would stay together? For local development and CI it's essential to have cmake generate the bundle (or else you could make changes in the C library that break the Python package and CI wouldn't catch it). Also important to include copy from ../dist as a fallback so that installing by URL works via pip. I tested this on Mac and Windows and Linux but it probably needs some flushing out. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
