comphead commented on code in PR #5640:
URL: https://github.com/apache/arrow-datafusion/pull/5640#discussion_r1141433380
##########
datafusion/expr/src/logical_plan/plan.rs:
##########
@@ -632,22 +631,21 @@ impl LogicalPlan {
/// params_values
pub fn replace_params_with_values(
&self,
- param_values: &Vec<ScalarValue>,
+ param_values: &[ScalarValue],
) -> Result<LogicalPlan, DataFusionError> {
Review Comment:
Perhaps its good to reuse existing `Result<LogicalPlan>` which already
`Result<T, DataFusionError>`. It will make the code less wordy
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
