HaoYang670 commented on code in PR #5640:
URL: https://github.com/apache/arrow-datafusion/pull/5640#discussion_r1141605774
##########
datafusion/expr/src/logical_plan/plan.rs:
##########
@@ -632,22 +631,21 @@ impl LogicalPlan {
/// params_values
pub fn replace_params_with_values(
&self,
- param_values: &Vec<ScalarValue>,
+ param_values: &[ScalarValue],
) -> Result<LogicalPlan, DataFusionError> {
Review Comment:
Thank you @comphead. I will also file an issue to track the `custom lint`
and find if there are more needs in our project to enable it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
