HaoYang670 commented on code in PR #5640:
URL: https://github.com/apache/arrow-datafusion/pull/5640#discussion_r1141546182
##########
datafusion/expr/src/logical_plan/plan.rs:
##########
@@ -632,22 +631,21 @@ impl LogicalPlan {
/// params_values
pub fn replace_params_with_values(
&self,
- param_values: &Vec<ScalarValue>,
+ param_values: &[ScalarValue],
) -> Result<LogicalPlan, DataFusionError> {
Review Comment:
Thank you @comphead. Actually, I have noticed this, but as we always use
`Result<_, DatafusionError>` in the file `plan.rs`, I didn't change it.
It is a good idea to file an issue to clean the `Result<_, DatafusionError>`
usages in the project. But I think a more elegant way it to try to implement
our own lint so that we can find it during the `cargo clippy`.
I've searched how to implement custom lints, but made less progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
