Dandandan commented on code in PR #3939:
URL: https://github.com/apache/arrow-rs/pull/3939#discussion_r1148354851
##########
arrow-cast/src/parse.rs:
##########
@@ -614,14 +614,21 @@ pub fn parse_decimal<T: DecimalType>(
scale: i8,
) -> Result<T::Native, ArrowError> {
let mut seen_dot = false;
Review Comment:
Instead of tracking `seen_dot` might also be more efficient to have 2 code
paths for handling the part before / after dot separately.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
