tustvold commented on code in PR #3939:
URL: https://github.com/apache/arrow-rs/pull/3939#discussion_r1148365876
##########
arrow-cast/src/parse.rs:
##########
@@ -1705,5 +1695,58 @@ mod tests {
"actual: '{actual_256}', expected: '{expected_256}'"
);
}
+
+ let edge_tests_128 = [
+ (
+ "99999999999999999999999999999999999999",
+ 99999999999999999999999999999999999999i128,
+ 0,
+ ),
+ (
+ "999999999999999999999999999999999999.99",
+ 99999999999999999999999999999999999999i128,
+ 2,
+ ),
+ (
+ "9999999999999999999999999.9999999999999",
+ 99999999999999999999999999999999999999i128,
+ 13,
+ ),
+ (
+ "9999999999999999999999999",
+ 99999999999999999999999990000000000000i128,
+ 13,
+ ),
Review Comment:
This test appears to be failing, I think a 0 digit in front of a decimal
shouldn't count to the precision
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
