tustvold commented on code in PR #3939:
URL: https://github.com/apache/arrow-rs/pull/3939#discussion_r1148355429
##########
arrow-cast/src/parse.rs:
##########
@@ -691,12 +681,12 @@ pub fn parse_decimal<T: DecimalType>(
if exp as u8 + digits > precision {
return Err(ArrowError::ParseError("parse decimal
overflow".to_string()));
}
- let mul = base.pow_checked(exp as _)?;
- result = result.mul_checked(mul)?;
+ let mul = base.pow_wrapping(exp as _);
Review Comment:
I'm fairly certain this is correct, but could we possibly get some tests of
numbers on the edge of overflowing?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
