rtpsw commented on code in PR #34627:
URL: https://github.com/apache/arrow/pull/34627#discussion_r1149516954
##########
cpp/proto/substrait/extension_rels.proto:
##########
@@ -58,3 +58,16 @@ message NamedTapRel {
// If empty, field names will be automatically generated.
repeated string columns = 3;
}
+
+message SegmentedAggregateRel {
+ substrait.RelCommon common = 1;
Review Comment:
I don't like this too much myself. The reason for this is technical, due to
the current extension API (which I didn't want to change in this PR).
Specifically, The [`MakeSegmentedAggregateRel`
method](https://github.com/apache/arrow/pull/34627/files#diff-8c5c127e8db8e52b40519262ee2b7e0179d4a39e5bcfe8b2165173b2b352d6a9R174)
does not have access to the `RelCommon` part of `ExtensionSingleRel`, but it
needs to [pass a
`RelCommon`](https://github.com/apache/arrow/pull/34627/files#diff-8c5c127e8db8e52b40519262ee2b7e0179d4a39e5bcfe8b2165173b2b352d6a9R221)
to the [`MakeAggregateDeclaration`
function](https://github.com/apache/arrow/pull/34627/files#diff-8c5c127e8db8e52b40519262ee2b7e0179d4a39e5bcfe8b2165173b2b352d6a9R220),
which [passes it to the `ProcessEmit`
function](https://github.com/apache/arrow/pull/34627/files#diff-2c7a2e65948433ab4aa1fb595d3132338b0e9684ed57f8021c28e448dd8a8ec2R384).
Perhaps a way to avoid this is to have pass a default `RelCommon` to
`MakeAggregateDeclaration`;
I'll need to check.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
