rtpsw commented on code in PR #34627: URL: https://github.com/apache/arrow/pull/34627#discussion_r1149521627
########## cpp/src/arrow/engine/substrait/expression_internal.cc: ########## @@ -138,6 +138,77 @@ std::string EnumToString(int value, const google::protobuf::EnumDescriptor* desc return value_desc->name(); } +Result<compute::Expression> FromProto(const substrait::Expression::ReferenceSegment* ref, Review Comment: Yes, this is a refactoring which extracted part of the original code that handled a reference segment into a reusable function. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
