jiangzhx commented on PR #5686: URL: https://github.com/apache/arrow-datafusion/pull/5686#issuecomment-1488168803
> > Because when I started to remove the duplicate logic between the DataFrame API and SQL planning, I found that count_wildcard_rule did not cover all scenarios, such as union, window, etc. > > This makes sense -- thank you for the explanation @jiangzhx > > Can you please add DataFrame tests the relevant behavior (mostly so that we don't break it in the future by accident) i add some testcase in tests/dataframe.rs - test_count_wildcard_on_sort - test_count_wildcard_on_where_exist - test_count_wildcard_on_window - test_count_wildcard_on_aggregate -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
