jiangzhx commented on PR #5686: URL: https://github.com/apache/arrow-datafusion/pull/5686#issuecomment-1486618404
> I am sorry for the delay in review. I will try and find more time to review this carefully tomorrow but initially I am surprised that says it removes duplicated logic adds more code than it removes 🤔 Because when I started to remove the duplicate logic between the DataFrame API and SQL planning, I found that count_wildcard_rule did not cover all scenarios, such as union, window, etc. Currently, these test cases are all based on SQL, so they are not discovered when running cargo test. After I covered more scenarios for count_wildcard_rule, it resulted in more code added than removed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
