icexelloss commented on code in PR #34627:
URL: https://github.com/apache/arrow/pull/34627#discussion_r1150611793
##########
cpp/proto/substrait/extension_rels.proto:
##########
@@ -58,3 +58,14 @@ message NamedTapRel {
// If empty, field names will be automatically generated.
repeated string columns = 3;
}
+
+message SegmentedAggregateRel {
+ // Grouping keys of the aggregation
+ repeated substrait.Expression.ReferenceSegment grouping_keys = 2;
Review Comment:
From looking at existing substrait messages. `FieldReference` is what is
commonly used to represent "keys" so I think we should use that type here.
@westonpace WDTY?
##########
cpp/proto/substrait/extension_rels.proto:
##########
@@ -58,3 +58,16 @@ message NamedTapRel {
// If empty, field names will be automatically generated.
repeated string columns = 3;
}
+
+message SegmentedAggregateRel {
+ substrait.RelCommon common = 1;
+
+ // Grouping keys of the aggregation
+ repeated substrait.Expression.ReferenceSegment grouping_keys = 2;
+
+ // Segment keys of the aggregation
+ repeated substrait.Expression.ReferenceSegment segment_keys = 3;
+
+ // A list of one or more aggregate expressions along with an optional filter.
+ repeated substrait.AggregateRel.Measure measures = 4;
Review Comment:
kk sounds good to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
