icexelloss commented on code in PR #34627:
URL: https://github.com/apache/arrow/pull/34627#discussion_r1150640663
##########
cpp/src/arrow/engine/substrait/relation_internal.cc:
##########
@@ -293,6 +303,90 @@ Status DiscoverFilesFromDir(const
std::shared_ptr<fs::LocalFileSystem>& local_fs
return Status::OK();
}
+namespace internal {
Review Comment:
Actually I see what you are doing here - these two methods are not "API"
methods in the same sense that the other "FromProto" methods are and takes a
lot of internal parameters.
We can leave as is. But can you put a comment about how the methods here are
different from the rest of the methods here. I didn't understand why do meant
by "Called sparsely" - but I guess you mean that "these two methods are only
meant to be used inside FromProto of AggregationRel and
SegementedAggregationRel"?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
