rtpsw commented on code in PR #34627:
URL: https://github.com/apache/arrow/pull/34627#discussion_r1150647593
##########
cpp/proto/substrait/extension_rels.proto:
##########
@@ -58,3 +58,14 @@ message NamedTapRel {
// If empty, field names will be automatically generated.
repeated string columns = 3;
}
+
+message SegmentedAggregateRel {
+ // Grouping keys of the aggregation
+ repeated substrait.Expression.ReferenceSegment grouping_keys = 2;
+
+ // Segment keys of the aggregation
+ repeated substrait.Expression.ReferenceSegment segment_keys = 3;
Review Comment:
Probably doesn't matter. If there are other changes needed, I could include
this.
##########
cpp/proto/substrait/extension_rels.proto:
##########
@@ -58,3 +58,14 @@ message NamedTapRel {
// If empty, field names will be automatically generated.
repeated string columns = 3;
}
+
+message SegmentedAggregateRel {
+ // Grouping keys of the aggregation
+ repeated substrait.Expression.ReferenceSegment grouping_keys = 2;
Review Comment:
IIRC, Weston's said this is fine in an extension.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
