alamb commented on code in PR #5685:
URL: https://github.com/apache/arrow-datafusion/pull/5685#discussion_r1150666599
##########
datafusion/core/tests/sqllogictests/test_files/aggregate.slt:
##########
@@ -1390,7 +1390,7 @@ as values
('2021-1-1T05:11:10.432', 'Row 3');
-statement ok
+statement error DataFusion error: Arrow error: Parser error: Error parsing
timestamp from '2021-1-1T05:11:10.432': error parsing date
Review Comment:
I think we should change the data in this test so it passes
Also, it looks like a slight regression to me in that parsing `2021-1-1`
used to parse and now doesn't.
So I suggest:
# 1. Change this test from
```
2021-1-1T05:11:10.432
```
to something like
```
2021-01-01T05:11:10.432
```
# 2 file an upstream ticket in arrow-rs to be more lenient
Aka to accept `2021-1-1T05:11:10.432` as valid -- I can do this if you like
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
