tustvold commented on code in PR #5685:
URL: https://github.com/apache/arrow-datafusion/pull/5685#discussion_r1150732948
##########
datafusion/core/tests/sqllogictests/test_files/aggregate.slt:
##########
@@ -1387,7 +1387,7 @@ as values
('2018-11-13T17:11:10.011375885995', 'Row 0'),
('2011-12-13T11:13:10.12345', 'Row 1'),
(null, 'Row 2'),
- ('2021-1-1T05:11:10.432', 'Row 3');
+ ('2021-01-01T05:11:10.432', 'Row 3');
Review Comment:
Arrow no longer supports timestamps of this shortened form, it has never
been documented to support them, and it is an accidental undocumented quirk of
chrono that it did. I would very strongly resist changing this, being able to
predict the digit locations ahead of time is critical to avoiding a data
dependency when parsing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
