tustvold commented on code in PR #5685:
URL: https://github.com/apache/arrow-datafusion/pull/5685#discussion_r1150723143
##########
datafusion/core/tests/sqllogictests/test_files/aggregate.slt:
##########
@@ -1390,7 +1390,7 @@ as values
('2021-1-1T05:11:10.432', 'Row 3');
-statement ok
+statement error DataFusion error: Arrow error: Parser error: Error parsing
timestamp from '2021-1-1T05:11:10.432': error parsing date
Review Comment:
> 1. Change this test from
Will do
> 2 file an upstream ticket in arrow-rs to be more lenient
I would strongly request we do not do this, it will severely hurt
performance for an incredibly esoteric use-case. It isn't actually documented
that chrono supports this, and we have never intentionally supported it either
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
