paleolimbot commented on code in PR #169:
URL: https://github.com/apache/arrow-nanoarrow/pull/169#discussion_r1152634978
##########
extensions/nanoarrow_ipc/CMakeLists.txt:
##########
@@ -16,9 +16,13 @@
# under the License.
message(STATUS "Building using CMake version: ${CMAKE_VERSION}")
-cmake_minimum_required(VERSION 3.11)
+cmake_minimum_required(VERSION 3.14)
include(FetchContent)
+if(NOT DEFINED CMAKE_C_STANDARD)
+ set(CMAKE_C_STANDARD 11)
Review Comment:
We don't actually need C11 here but it's preferred since it gets us
thread-safe shared buffers. We do need to specify a C standard if unset,
though, because some compilers default to pre C99 and that won't fly. I should
probably add an explicit test for what happens when C99 is set, though (maybe a
future PR though).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
