paleolimbot commented on code in PR #169:
URL: https://github.com/apache/arrow-nanoarrow/pull/169#discussion_r1152666436
##########
extensions/nanoarrow_ipc/CMakeLists.txt:
##########
@@ -181,11 +185,24 @@ if (NANOARROW_IPC_BUILD_TESTS)
message(STATUS "Arrow SO version: ${ARROW_FULL_SO_VERSION}")
# Warning about timestamps of downloaded files
- cmake_policy(SET CMP0135 NEW)
- FetchContent_Declare(
- googletest
- URL https://github.com/google/googletest/archive/release-1.11.0.zip
- )
+ if (${CMAKE_VERSION} VERSION_GREATER_EQUAL "3.23")
+ cmake_policy(SET CMP0135 NEW)
+ endif()
+
+ # Use an old version of googletest if we have to to support gcc 4.8
+ if(NOT CMAKE_CXX_COMPILER_ID STREQUAL "GNU" OR
+ CMAKE_CXX_COMPILER_VERSION VERSION_GREATER_EQUAL "5.0.0")
+ FetchContent_Declare(
+ googletest
+ URL https://github.com/google/googletest/archive/release-1.11.0.zip
Review Comment:
Good call!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
