paleolimbot commented on code in PR #169:
URL: https://github.com/apache/arrow-nanoarrow/pull/169#discussion_r1152666166
##########
extensions/nanoarrow_ipc/CMakeLists.txt:
##########
@@ -199,8 +216,20 @@ if (NANOARROW_IPC_BUILD_TESTS)
target_link_libraries(nanoarrow_ipc PRIVATE ipc_coverage_config)
endif()
- target_link_libraries(nanoarrow_ipc_decoder_test nanoarrow_ipc nanoarrow
arrow_shared gtest_main)
- target_link_libraries(nanoarrow_ipc_reader_test nanoarrow_ipc nanoarrow
gtest_main)
+ # On Windows, dynamically linking Arrow is difficult to get right,
+ # so use static linking by default.
+ if (MSVC)
+ set(NANOARROW_IPC_ARROW_TARGET arrow_static)
+ else()
+ set(NANOARROW_IPC_ARROW_TARGET arrow_shared)
+ endif()
Review Comment:
But it does fit on one line! I left this one as is because I don't
understand it yet (but I am glad to know it exists!)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
