icexelloss commented on code in PR #34711:
URL: https://github.com/apache/arrow/pull/34711#discussion_r1154802867
##########
r/configure:
##########
@@ -265,6 +265,12 @@ if [ $? -eq 0 ]; then
# NOTE: parquet is assumed to have the same -L flag as arrow
# so there is no need to add its location to PKG_DIRS
fi
+ if arrow_built_with ARROW_ACERO; then
+ PKG_CFLAGS="$PKG_CFLAGS -DARROW_R_WITH_ACERO"
+ PKG_LIBS="-larrow_acero $PKG_LIBS"
+ # NOTE: arrow-dataset is assumed to have the same -L flag as arrow
Review Comment:
Updated
##########
cpp/src/arrow/acero/exec_plan.cc:
##########
@@ -1048,7 +1048,7 @@ Result<std::unique_ptr<RecordBatchReader>>
DeclarationToReader(
return DeclarationToReader(std::move(declaration), std::move(options));
}
-namespace internal {
+namespace acerointernal {
Review Comment:
reverted
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
