disq commented on code in PR #34631:
URL: https://github.com/apache/arrow/pull/34631#discussion_r1158365016
##########
go/parquet/pqarrow/column_readers.go:
##########
@@ -546,6 +551,14 @@ func transferBinary(rdr file.RecordReader, dt
arrow.DataType) *arrow.Chunked {
defer chunks[idx].Data().Release()
defer chunks[idx].Release()
}
+ } else if dt.ID() == arrow.EXTENSION && len(chunks) > 0 &&
arrow.StorageTypeEqual(chunks[0].DataType(), dt) &&
!arrow.TypeEqual(chunks[0].DataType(), dt) {
Review Comment:
The resulting code seems harder to follow as both cases are now somewhat
intertwined.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
