disq commented on code in PR #34631:
URL: https://github.com/apache/arrow/pull/34631#discussion_r1158365892
##########
go/parquet/pqarrow/column_readers.go:
##########
@@ -459,8 +459,13 @@ func chunksToSingle(chunked *arrow.Chunked)
(arrow.ArrayData, error) {
// create a chunked arrow array from the raw record data
func transferColumnData(rdr file.RecordReader, valueType arrow.DataType, descr
*schema.Column, mem memory.Allocator) (*arrow.Chunked, error) {
+ valueID := valueType.ID()
+ if valueID == arrow.EXTENSION {
+ valueID = valueType.(arrow.ExtensionType).StorageType().ID()
+ }
Review Comment:
I think we're missing a test here because the change seems to work without
implementing the last part you described... I'll take a detailed look later.
##########
go/parquet/pqarrow/column_readers.go:
##########
@@ -459,8 +459,13 @@ func chunksToSingle(chunked *arrow.Chunked)
(arrow.ArrayData, error) {
// create a chunked arrow array from the raw record data
func transferColumnData(rdr file.RecordReader, valueType arrow.DataType, descr
*schema.Column, mem memory.Allocator) (*arrow.Chunked, error) {
+ valueID := valueType.ID()
+ if valueID == arrow.EXTENSION {
+ valueID = valueType.(arrow.ExtensionType).StorageType().ID()
+ }
Review Comment:
I think we're missing a test here because the change you proposed seems to
work without implementing the last part you described... I'll take a detailed
look later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
