yevgenypats commented on code in PR #34986:
URL: https://github.com/apache/arrow/pull/34986#discussion_r1164367508
##########
go/arrow/array/numericbuilder.gen.go.tmpl:
##########
@@ -184,6 +184,124 @@ func (b *{{.Name}}Builder) newData() (data *Data) {
return
}
+func (b *{{.Name}}Builder) AppendValueFromString(s string) error {
+ if s == NullValueStr {
+ b.AppendNull()
+ return nil
+ }
+ {{if or (eq .Name "Date32") -}}
+ tm, err := time.Parse("2006-01-02", s)
+ if err != nil {
+ b.AppendNull()
+ return err
+ }
+ b.Append(arrow.Date32FromTime(tm))
Review Comment:
The problem with the indentation here is because in this file we use tabs
instead of spaces. should we all turn it into spaces or should I keep using
tabs in this file while in all `.go` files we do use spaces I believe. wdyt?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
