yevgenypats commented on code in PR #34986:
URL: https://github.com/apache/arrow/pull/34986#discussion_r1165381313
##########
go/arrow/array/struct_test.go:
##########
@@ -290,15 +291,17 @@ func TestStructArrayStringer(t *testing.T) {
f2b.Append(f2s[i])
}
}
-
+ assert.NoError(t, sb.AppendValueFromString(`{"f1": 1.1, "f2": 1}`))
arr := sb.NewArray().(*array.Struct)
defer arr.Release()
- want := "{[1.1 (null) 1.3 1.4] [1 2 (null) 4]}"
+ assert.Equal(t, "{\"f1\":1.1,\"f2\":1}\n", arr.ValueStr(4))
+ want := "{[1.1 (null) 1.3 1.4 1.1] [1 2 (null) 4 1]}"
got := arr.String()
if got != want {
t.Fatalf("invalid string representation:\ngot = %q\nwant= %q",
got, want)
}
+ // assert.Equal(t, "[1.1 (null) 1.3 1.4]", arr.ValueStr(0))
Review Comment:
Removed. I already test the method on line `298`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
