kou commented on code in PR #34842: URL: https://github.com/apache/arrow/pull/34842#discussion_r1170558285
########## swift/Arrow/swift-datagen: ########## Review Comment: How did you generate this binary? ########## swift/gen-flatbuffers.sh: ########## @@ -0,0 +1,26 @@ +#!/usr/bin/env bash + +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + Review Comment: FYI: We can check "failed to execute a command" and "referred a nonexistent variable" automatically by `set -eu` (`-e` is for "failed to execute a command" and `-u` is for "referred a nonexistent variable"): ```suggestion set -eu ``` ########## swift/gen-flatbuffers.sh: ########## @@ -0,0 +1,26 @@ +#!/usr/bin/env bash + +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +pushd Arrow/Sources/Arrow/ +flatc --swift ../../../../format/Message.fbs +flatc --swift ../../../../format/Schema.fbs +flatc --swift ../../../../format/SparseTensor.fbs +flatc --swift ../../../../format/Tensor.fbs +flatc --swift ../../../../format/File.fbs +popd Review Comment: Could you prepend our license header to the generated files? ```suggestion cat <<HEADER > header.swift // Licensed to the Apache Software Foundation (ASF) under one // or more contributor license agreements. See the NOTICE file // distributed with this work for additional information // regarding copyright ownership. The ASF licenses this file // to you under the Apache License, Version 2.0 (the // "License"); you may not use this file except in compliance // with the License. You may obtain a copy of the License at // // http://www.apache.org/licenses/LICENSE-2.0 // // Unless required by applicable law or agreed to in writing, // software distributed under the License is distributed on an // "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY // KIND, either express or implied. See the License for the // specific language governing permissions and limitations // under the License. HEADER for generated_swift in *_generated.swift; do mv ${generated_swift} ${generated_swift}.orig cat header.swift ${generated_swift}.orig > ${generated_swift} rm ${generated_swift}.orig done rm header.swift popd ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
