kou commented on code in PR #34842:
URL: https://github.com/apache/arrow/pull/34842#discussion_r1179861325


##########
swift/Arrow/swift-datagen:
##########


Review Comment:
   Could you remove this from this repository and build it on CI time instead?
   I don't want to add auto generated files as much as possible.



##########
swift/Arrow/README.md:
##########
@@ -47,3 +47,10 @@ An implementation of Arrow targeting Swift.
 - Data Types
 - Fields
 - Schema
+
+## Test data generation
+
+Test data files for the reader tests are generated by an executable built in 
go whose source is included in the data-generator directory.  
+```sh

Review Comment:
   ```suggestion
   ```console
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to