kou commented on code in PR #34842: URL: https://github.com/apache/arrow/pull/34842#discussion_r1170708137
########## swift/Arrow/swift-datagen: ########## Review Comment: Hmm. Does it mean that your next pull request implements double/bool writer? And the following pull requests implement reader and writer at once instead of implementing reader with test data then implementing writer and remove the test data like this, right? If so, we can embed the two test data into our test in base64 as you did because they are temporary, we don't update them and we don't add other test data. If we still keep implementing reader with test data then implementing writer and remove the test data style, I think that we should add source code of test data generator program so that anyone can join the Swift implementation development. See also: The Apache Way: Open: https://theapacheway.com/open/ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
