icexelloss commented on code in PR #34912:
URL: https://github.com/apache/arrow/pull/34912#discussion_r1170588374
##########
cpp/src/arrow/compute/kernels/hash_aggregate.cc:
##########
@@ -1695,6 +1692,389 @@ struct GroupedMinMaxFactory {
InputType argument_type;
};
+// ----------------------------------------------------------------------
+// FirstLast implementation
+
+template <typename CType>
+struct NullSentinel {
+ static constexpr CType value() { return std::numeric_limits<CType>::min(); }
+};
+
+template <>
+struct NullSentinel<float> {
+ static constexpr float value() { return
std::numeric_limits<float>::infinity(); }
+};
+
+template <>
+struct NullSentinel<double> {
+ static constexpr double value() { return
std::numeric_limits<double>::infinity(); }
+};
+
+template <typename Type, typename Enable = void>
+struct GroupedFirstLastImpl final : public GroupedAggregator {
Review Comment:
This class follows the GroupedMinMaxImpl with slight modification of the
Consume and Merge function (to compute first/last instead of min/max)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
