icexelloss commented on code in PR #34912:
URL: https://github.com/apache/arrow/pull/34912#discussion_r1173123685
##########
cpp/src/arrow/compute/kernels/hash_aggregate.cc:
##########
@@ -1251,6 +1251,210 @@ HashAggregateKernel
MakeApproximateMedianKernel(HashAggregateFunction* tdigest_f
return kernel;
}
+// ----------------------------------------------------------------------
+// FirstLast implementation
+
+template <typename CType>
+struct NullSentinel {
+ static constexpr CType value() { return std::numeric_limits<CType>::min(); }
+};
+
+template <>
+struct NullSentinel<float> {
+ static constexpr float value() { return
std::numeric_limits<float>::infinity(); }
+};
+
+template <>
+struct NullSentinel<double> {
+ static constexpr double value() { return
std::numeric_limits<double>::infinity(); }
+};
Review Comment:
I removed this and ended up reusing AntiExtrema for the sentinel values
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
