icexelloss commented on code in PR #34912:
URL: https://github.com/apache/arrow/pull/34912#discussion_r1173073955
##########
cpp/src/arrow/compute/kernels/hash_aggregate.cc:
##########
@@ -105,22 +105,19 @@ Result<TypeHolder> ResolveGroupOutputType(KernelContext*
ctx,
}
HashAggregateKernel MakeKernel(std::shared_ptr<KernelSignature> signature,
- KernelInit init) {
- HashAggregateKernel kernel;
- kernel.init = std::move(init);
- kernel.signature = std::move(signature);
- kernel.resize = HashAggregateResize;
- kernel.consume = HashAggregateConsume;
- kernel.merge = HashAggregateMerge;
- kernel.finalize = HashAggregateFinalize;
+ KernelInit init, const bool ordered = false) {
+ HashAggregateKernel kernel(std::move(signature), std::move(init),
HashAggregateResize,
Review Comment:
same as original code, but refactored a bit so that we cannot have an
partially initialized kernel here (the constructor makes sure of that)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
