icexelloss commented on code in PR #34912:
URL: https://github.com/apache/arrow/pull/34912#discussion_r1173130436
##########
cpp/src/arrow/acero/aggregate_node.cc:
##########
@@ -350,7 +350,14 @@ class ScalarAggregateNode : public ExecNode, public
TracedNode {
kernel_intypes[i] = in_types;
ARROW_ASSIGN_OR_RAISE(const Kernel* kernel,
function->DispatchExact(kernel_intypes[i]));
- kernels[i] = static_cast<const ScalarAggregateKernel*>(kernel);
+ const ScalarAggregateKernel* agg_kernel =
+ static_cast<const ScalarAggregateKernel*>(kernel);
+ if (concurrency > 1 && agg_kernel->ordered) {
Review Comment:
We only support ordered aggregator in serial execution
##########
cpp/src/arrow/acero/aggregate_node.cc:
##########
@@ -350,7 +350,14 @@ class ScalarAggregateNode : public ExecNode, public
TracedNode {
kernel_intypes[i] = in_types;
ARROW_ASSIGN_OR_RAISE(const Kernel* kernel,
function->DispatchExact(kernel_intypes[i]));
- kernels[i] = static_cast<const ScalarAggregateKernel*>(kernel);
+ const ScalarAggregateKernel* agg_kernel =
+ static_cast<const ScalarAggregateKernel*>(kernel);
+ if (concurrency > 1 && agg_kernel->ordered) {
Review Comment:
We currently only support ordered aggregator in serial execution
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
