metesynnada commented on code in PR #6049: URL: https://github.com/apache/arrow-datafusion/pull/6049#discussion_r1177515381
########## datafusion/core/src/physical_plan/memory_insert.rs: ########## @@ -0,0 +1,661 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +//! Execution plan for writing in-memory batches of data + +use std::any::Any; +use std::sync::Arc; +use std::task::{Context, Poll}; +use std::{fmt, mem}; + +use crate::physical_plan::{ + DisplayFormatType, Distribution, ExecutionPlan, Partitioning, RecordBatchStream, + SendableRecordBatchStream, +}; + +use arrow::datatypes::SchemaRef; +use arrow::record_batch::RecordBatch; +use datafusion_common::{Result, Statistics}; +use datafusion_execution::TaskContext; +use datafusion_physical_expr::PhysicalSortExpr; +use futures::FutureExt; +use futures::{ready, Stream, StreamExt}; +use tokio::sync::{OwnedRwLockWriteGuard, RwLock}; + +// Type alias for partition data +type PartitionData = Arc<RwLock<Vec<RecordBatch>>>; + +// Macro to simplify polling a future +macro_rules! ready_poll { + ($e:expr, $cx:expr) => { + ready!(Box::pin($e).poll_unpin($cx)) Review Comment: Did you try it in code? It will produce an error since lock future (`impl Future<Output = RwLockWriteGuard<'_, Vec<RecordBatch>>>`) does not implement `Unpin`. `BoxFuture`s are implementing this, I think you made the same thing in `FileStreamState`? Is there another poll method that does not require pinning the future? I could use that. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
