metesynnada commented on code in PR #6049:
URL: https://github.com/apache/arrow-datafusion/pull/6049#discussion_r1179120795
##########
datafusion/core/src/datasource/datasource.rs:
##########
@@ -102,8 +102,8 @@ pub trait TableProvider: Sync + Send {
async fn insert_into(
&self,
_state: &SessionState,
- _input: &LogicalPlan,
- ) -> Result<()> {
+ _input: Arc<dyn ExecutionPlan>,
+ ) -> Result<Arc<dyn ExecutionPlan>> {
Review Comment:
Hi @aprimadi, thanks for the question 😀. If this is the only consideration,
yes it would be able to do so with some workarounds. However, this is not the
correct design pattern for providing the concurrency. We usually use the
`execute()` API in `ExecutionPlan` to achieve this type of parallelism since it
would have the input partition information, its output partition count, etc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
