alamb commented on code in PR #6049:
URL: https://github.com/apache/arrow-datafusion/pull/6049#discussion_r1178155013
##########
datafusion/core/src/physical_plan/memory.rs:
##########
@@ -223,15 +245,365 @@ impl RecordBatchStream for MemoryStream {
}
}
+/// Execution plan for writing record batches to an in-memory table.
+pub struct MemoryWriteExec {
Review Comment:
I may have misunderstood the discussion on
https://github.com/apache/arrow-datafusion/issues/5076#issuecomment-1523554165
But I thought the consensus was to have a generic ExecutionPlan for writing
data, rather than one that was specific to MemTable
So something like
```
pub struct MemoryWriteExec {
/// Input plan that produces the record batches to be written.
input: Arc<dyn ExecutionPlan>,
/// Target TableProvider (or table factory?).
target: Arc<dyn TableFactory>,
/// Schema describing the structure of the data.
schema: SchemaRef,
}
```
🤔
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]