icexelloss commented on code in PR #35513:
URL: https://github.com/apache/arrow/pull/35513#discussion_r1188822415
##########
cpp/src/arrow/engine/substrait/function_test.cc:
##########
@@ -574,6 +575,8 @@ struct AggregateTestCase {
std::shared_ptr<DataType> output_type;
// The aggregation takes zero columns as input
bool nullary = false;
+ // The aggregation is ordered
+ bool ordered = false;
Review Comment:
If aggregation is ordered, shouldn't this be true?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
