rtpsw commented on code in PR #35513:
URL: https://github.com/apache/arrow/pull/35513#discussion_r1188888525
##########
cpp/src/arrow/engine/substrait/serde.cc:
##########
@@ -236,14 +236,13 @@ ARROW_ENGINE_EXPORT Result<PlanInfo> DeserializePlan(
namespace {
-Result<std::shared_ptr<acero::ExecPlan>> MakeSingleDeclarationPlan(
- std::vector<acero::Declaration> declarations) {
+Status MakeSingleDeclarationPlan(acero::ExecPlan* plan,
Review Comment:
This allows one to pass a preconfigured plan instead of getting a
default-configured plan. The tester uses this to pass a plan with a non-default
executor `ctx_for_ordered`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
