rtpsw commented on code in PR #35513:
URL: https://github.com/apache/arrow/pull/35513#discussion_r1188887214
##########
cpp/src/arrow/engine/substrait/function_test.cc:
##########
@@ -574,6 +575,8 @@ struct AggregateTestCase {
std::shared_ptr<DataType> output_type;
// The aggregation takes zero columns as input
bool nullary = false;
+ // The aggregation is ordered
+ bool ordered = false;
Review Comment:
The pre-PR behavior is equivalent to post-PR behavior with `ordered =
false`. In pre-PR, all tested aggregators had no trouble with the default
executor. In post-PR, the `first` and `last` aggregators are ordered and with
`ordered = false` there is an error `NotImplemented: Using ordered aggregator
in multiple threaded execution is not supported`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
