icexelloss commented on code in PR #35513:
URL: https://github.com/apache/arrow/pull/35513#discussion_r1189033347
##########
cpp/src/arrow/engine/substrait/serde.cc:
##########
@@ -236,14 +236,13 @@ ARROW_ENGINE_EXPORT Result<PlanInfo> DeserializePlan(
namespace {
-Result<std::shared_ptr<acero::ExecPlan>> MakeSingleDeclarationPlan(
- std::vector<acero::Declaration> declarations) {
+Status MakeSingleDeclarationPlan(acero::ExecPlan* plan,
Review Comment:
I think you can use
https://github.com/apache/arrow/blob/c3acc91c3e21f225ee7cc3cb3f489f0153365f5a/cpp/src/arrow/acero/exec_plan.h#L566
Instead and can avoid changing the serde files
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
