rtpsw commented on code in PR #35513:
URL: https://github.com/apache/arrow/pull/35513#discussion_r1190212541


##########
cpp/src/arrow/engine/substrait/serde.h:
##########
@@ -89,8 +89,7 @@ ARROW_ENGINE_EXPORT Result<std::vector<acero::Declaration>> 
DeserializePlans(
 /// \param[out] ext_set_out if non-null, the extension mapping used by the 
Substrait
 /// \param[in] conversion_options options to control how the conversion is to 
be done.
 /// Plan is returned here.
-/// \return an ExecNode corresponding to the single toplevel relation in the 
Substrait
-/// Plan
+/// \return an ExecPlan for the Substrait Plan

Review Comment:
   The pre-PR comment is incorrect, so I fixed it.



##########
cpp/src/arrow/engine/substrait/serde.h:
##########
@@ -133,8 +132,7 @@ ARROW_ENGINE_EXPORT Result<std::vector<acero::Declaration>> 
DeserializePlans(
 /// \param[out] ext_set_out if non-null, the extension mapping used by the 
Substrait
 /// Plan is returned here.
 /// \param[in] conversion_options options to control how the conversion is to 
be done.
-/// \return a vector of ExecNode declarations, one for each toplevel relation 
in the
-/// Substrait Plan
+/// \return an ExecPlan for the Substrait Plan

Review Comment:
   The pre-PR comment is incorrect, so I fixed it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to