icexelloss commented on code in PR #35513:
URL: https://github.com/apache/arrow/pull/35513#discussion_r1196577132
##########
cpp/src/arrow/engine/substrait/extension_set.cc:
##########
@@ -1113,9 +1113,11 @@ struct DefaultExtensionIdRegistry :
ExtensionIdRegistryImpl {
DecodeBasicAggregate("mean")));
DCHECK_OK(AddSubstraitAggregateToArrow({kSubstraitArithmeticFunctionsUri,
"std_dev"},
DecodeBasicAggregate("stddev")));
- DCHECK_OK(
- AddSubstraitAggregateToArrow({kSubstraitAggregateGenericFunctionsUri,
"count"},
- DecodeBasicAggregate("count")));
+ for (const auto& fn_name : {"count", "first", "last"}) {
+ DCHECK_OK(
+
AddSubstraitAggregateToArrow({kSubstraitAggregateGenericFunctionsUri, fn_name},
Review Comment:
Should we uri the arrow specifc uri for first/last instead of the substrait
one?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
