icexelloss commented on code in PR #35513:
URL: https://github.com/apache/arrow/pull/35513#discussion_r1191514243


##########
cpp/src/arrow/engine/substrait/function_test.cc:
##########
@@ -601,6 +603,7 @@ std::shared_ptr<Table> GetOutputTableForAggregateCase(
 std::shared_ptr<acero::ExecPlan> PlanFromAggregateCase(
     const AggregateTestCase& test_case, std::shared_ptr<Table>* output_table,
     bool with_keys) {
+  static ExecContext ctx_for_ordered;

Review Comment:
   This still feel strange to me that this is needed. Does something like this 
not work?
   
https://github.com/apache/arrow/blob/401ae19051e9120fedb8372a13cd68e08798c00a/cpp/src/arrow/acero/benchmark_util.cc#L49



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to