tustvold commented on code in PR #4220:
URL: https://github.com/apache/arrow-rs/pull/4220#discussion_r1194264850
##########
object_store/src/aws/client.rs:
##########
@@ -302,89 +268,6 @@ impl S3Client {
Ok(())
}
- /// Make an S3 List request
<https://docs.aws.amazon.com/AmazonS3/latest/API/API_ListObjectsV2.html>
- async fn list_request(
- &self,
- prefix: Option<&str>,
- delimiter: bool,
- token: Option<&str>,
- offset: Option<&str>,
- ) -> Result<(ListResult, Option<String>)> {
- let credential = self.get_credential().await?;
- let url = self.config.bucket_endpoint.clone();
-
- let mut query = Vec::with_capacity(4);
-
- // Note: the order of these matters to ensure the generated URL is
canonical
- if let Some(token) = token {
- query.push(("continuation-token", token))
- }
-
- if delimiter {
- query.push(("delimiter", DELIMITER))
- }
-
- query.push(("list-type", "2"));
-
- if let Some(prefix) = prefix {
- query.push(("prefix", prefix))
- }
-
- if let Some(offset) = offset {
- query.push(("start-after", offset))
- }
-
- let response = self
- .client
- .request(Method::GET, &url)
- .query(&query)
- .with_aws_sigv4(
- credential.as_ref(),
- &self.config.region,
- "s3",
- self.config.sign_payload,
- None,
- )
- .send_retry(&self.config.retry_config)
- .await
- .context(ListRequestSnafu)?
- .bytes()
- .await
- .context(ListResponseBodySnafu)?;
-
- let mut response: ListResponse =
quick_xml::de::from_reader(response.reader())
- .context(InvalidListResponseSnafu)?;
- let token = response.next_continuation_token.take();
-
- Ok((response.try_into()?, token))
- }
-
- /// Perform a list operation automatically handling pagination
- pub fn list_paginated(
Review Comment:
This is now implemented by ListClientExt
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
