alamb commented on code in PR #4220:
URL: https://github.com/apache/arrow-rs/pull/4220#discussion_r1197009970
##########
object_store/src/azure/client.rs:
##########
@@ -300,14 +267,59 @@ impl AzureClient {
Ok(())
}
+}
+#[async_trait]
+impl GetClient for AzureClient {
+ const STORE: &'static str = STORE;
+
+ /// Make an Azure GET request
+ /// <https://docs.microsoft.com/en-us/rest/api/storageservices/get-blob>
+ ///
<https://docs.microsoft.com/en-us/rest/api/storageservices/get-blob-properties>
+ async fn get_request(
+ &self,
+ path: &Path,
+ options: GetOptions,
+ head: bool,
+ ) -> Result<Response> {
+ let credential = self.get_credential().await?;
+ let url = self.config.path_url(path);
+ let method = match head {
+ true => Method::HEAD,
+ false => Method::GET,
+ };
+
+ let builder = self
+ .client
+ .request(method, url)
+ .header(CONTENT_LENGTH, HeaderValue::from_static("0"))
+ .body(Bytes::new());
+
+ let response = builder
+ .with_get_options(options)
+ .with_azure_authorization(&credential, &self.config.account)
+ .send_retry(&self.config.retry_config)
+ .await
+ .context(GetRequestSnafu {
+ path: path.as_ref(),
+ })?;
+
+ Ok(response)
+ }
+}
+
+#[async_trait]
+impl ListClient for AzureClient {
/// Make an Azure List request
<https://docs.microsoft.com/en-us/rest/api/storageservices/list-blobs>
async fn list_request(
&self,
prefix: Option<&str>,
delimiter: bool,
token: Option<&str>,
+ offset: Option<&str>,
) -> Result<(ListResult, Option<String>)> {
+ assert!(offset.is_none()); // Not yet supported
Review Comment:
This should return an error rather than panic'ing I think
##########
object_store/src/client/get.rs:
##########
@@ -0,0 +1,68 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+use crate::client::header::header_meta;
+use crate::path::Path;
+use crate::Result;
+use crate::{Error, GetOptions, GetResult, ObjectMeta};
+use async_trait::async_trait;
+use futures::{StreamExt, TryStreamExt};
+use reqwest::Response;
+
+#[async_trait]
+pub trait GetClient: Send + Sync + 'static {
Review Comment:
I think some this should have some comments / explination for what it is
doing
##########
object_store/src/azure/client.rs:
##########
@@ -346,22 +358,6 @@ impl AzureClient {
Ok((to_list_result(response, prefix)?, token))
}
-
- /// Perform a list operation automatically handling pagination
Review Comment:
This is now implemented indirectly via `ListClientExt`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
