tustvold commented on code in PR #4220:
URL: https://github.com/apache/arrow-rs/pull/4220#discussion_r1197524556
##########
object_store/src/azure/client.rs:
##########
@@ -300,14 +267,59 @@ impl AzureClient {
Ok(())
}
+}
+#[async_trait]
+impl GetClient for AzureClient {
+ const STORE: &'static str = STORE;
+
+ /// Make an Azure GET request
+ /// <https://docs.microsoft.com/en-us/rest/api/storageservices/get-blob>
+ ///
<https://docs.microsoft.com/en-us/rest/api/storageservices/get-blob-properties>
+ async fn get_request(
+ &self,
+ path: &Path,
+ options: GetOptions,
+ head: bool,
+ ) -> Result<Response> {
+ let credential = self.get_credential().await?;
+ let url = self.config.path_url(path);
+ let method = match head {
+ true => Method::HEAD,
+ false => Method::GET,
+ };
+
+ let builder = self
+ .client
+ .request(method, url)
+ .header(CONTENT_LENGTH, HeaderValue::from_static("0"))
+ .body(Bytes::new());
+
+ let response = builder
+ .with_get_options(options)
+ .with_azure_authorization(&credential, &self.config.account)
+ .send_retry(&self.config.retry_config)
+ .await
+ .context(GetRequestSnafu {
+ path: path.as_ref(),
+ })?;
+
+ Ok(response)
+ }
+}
+
+#[async_trait]
+impl ListClient for AzureClient {
/// Make an Azure List request
<https://docs.microsoft.com/en-us/rest/api/storageservices/list-blobs>
async fn list_request(
&self,
prefix: Option<&str>,
delimiter: bool,
token: Option<&str>,
+ offset: Option<&str>,
) -> Result<(ListResult, Option<String>)> {
+ assert!(offset.is_none()); // Not yet supported
Review Comment:
It is unreachable by the current code
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
