lidavidm commented on code in PR #679:
URL: https://github.com/apache/arrow-adbc/pull/679#discussion_r1195071157
##########
c/driver/postgresql/connection.cc:
##########
@@ -182,7 +216,12 @@ AdbcStatusCode PostgresConnectionGetObjectsImpl(
if (depth == ADBC_OBJECT_DEPTH_CATALOGS) {
CHECK_NA(INTERNAL, ArrowArrayAppendNull(catalog_db_schemas_col, 1),
error);
} else {
- return ADBC_STATUS_NOT_IMPLEMENTED;
+ if (depth >= ADBC_OBJECT_DEPTH_DB_SCHEMAS) {
+ RAISE_ADBC(PostgresConnectionGetSchemasImpl(conn, depth,
Review Comment:
You can see this starting here:
https://github.com/apache/arrow-adbc/blob/47775a82caf49b9c7a706717f4204cd98b5efcf8/c/validation/adbc_validation.cc#L564
The code I'm referencing for building up the structure is here:
https://github.com/apache/arrow-adbc/blob/main/go/adbc/driver/internal/shared_utils.go
You could also reference the code here:
https://github.com/apache/arrow/pull/14082
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
